add language filtering for codeql#39327
Conversation
|
/gemini review |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Assigning reviewers: R: @damccorm for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
CC: @shunping |
damccorm
left a comment
There was a problem hiding this comment.
Neat, this is a nice approach
| - 'sdks/go/**' | ||
| - 'playground/backend/**' | ||
| - 'learning/katas/go/**' | ||
| - 'learning/tour-of-beam/backend/**' |
There was a problem hiding this comment.
Can we just filter for files with an extension of .go? Similar for other languages (not actions, though)
There was a problem hiding this comment.
How about a compromise of adding the language extension, but also include the dependency and build configurations as well? Thanks
|
Love it! Thanks for spending time on it. |
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.