make image::fetch() implicitly declare lod 0#490
Merged
Conversation
Firestar99
force-pushed
the
image_fetch_lod0
branch
2 times, most recently
from
December 16, 2025 14:18
cb5c920 to
80ea5bd
Compare
Firestar99
marked this pull request as ready for review
December 16, 2025 14:18
Collaborator
|
@schell you know more graphics stuff, can you review this? |
Member
Author
|
I don't have a good compiletest to offer, other than naga chokes on |
* glsl [`texelFetch(sampler, coordinate, lod)`](https://docs.gl/sl4/texelFetch) takes the lod as an explicit parameter, so you can't emit a texel fetch in glsl without explicit lod * naga doesn't understand texel fetch without explicit lod
Firestar99
force-pushed
the
image_fetch_lod0
branch
from
February 19, 2026 18:18
80ea5bd to
537224e
Compare
LegNeato
approved these changes
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
texelFetch(sampler, coordinate, lod)takes the lod as an explicit parameter, so you can't emit a texel fetch in glsl without explicit lod