feat(voice): Remove input device requirement for starting/accepting calls#41287
feat(voice): Remove input device requirement for starting/accepting calls#41287gabriellsh wants to merge 2 commits into
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41287 +/- ##
===========================================
- Coverage 69.52% 69.37% -0.15%
===========================================
Files 3663 3680 +17
Lines 145125 145510 +385
Branches 25726 25808 +82
===========================================
+ Hits 100896 100946 +50
- Misses 39945 40265 +320
- Partials 4284 4299 +15
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Updates
media-signalingpackage device handling by removing "input track requirement` when starting/answering a call (e.g. Start a call without a microphone).Updates
ui-voippackage device permission handling by allowing calls to start even if the permission request failed. Also updates necessary UI/UX where necessary to allow for enabling microphone after call is in progress.Issue(s)
SSGA-20
Steps to test or reproduce
Further comments