[NET-1341] update: Use new split version of initialse multi turn runs and user message generation#334
Open
muhammedrazalak wants to merge 3 commits into
Open
[NET-1341] update: Use new split version of initialse multi turn runs and user message generation#334muhammedrazalak wants to merge 3 commits into
muhammedrazalak wants to merge 3 commits into
Conversation
| item_context = await run_before(hooks, dataset_item_id, shared_context) | ||
| setup_contexts[run_item_id] = item_context | ||
| except Exception as exc: | ||
| error_msg = f"before hook failed: {exc}" |
Collaborator
There was a problem hiding this comment.
Is it okay to skip run_after_all() if run_before() fails for all items?
| return sim_item | ||
|
|
||
| async def _run_all_before_and_first_turns() -> list[Optional[SimulationItem]]: | ||
| return list(await asyncio.gather(*[run_before_and_generate_first_turn(item) for item in items])) |
Collaborator
There was a problem hiding this comment.
self._client.generate_first_turn(...) is a synchronous, blocking httpx call invoked directly in the coroutine. It blocks the event loop, so the asyncio.gather yields no concurrency for them. Try switching to the ThreadPool Executor as we did for the conversation loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
after_allreceives complete results.Testing