fix(extension): show Base URL before API Key for custom provider#206
Open
achuvyas-kv wants to merge 1 commit into
Open
fix(extension): show Base URL before API Key for custom provider#206achuvyas-kv wants to merge 1 commit into
achuvyas-kv wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThe extension version changes to 0.10.1. The hidden Base URL field moves before the API Key field in the provider configuration UI, and an accompanying comment is updated. ChangesExtension update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the extension popup, when Custom (OpenAI-compatible) or Azure is selected, API Key appeared before Base URL. That order is awkward for custom endpoints — users typically set the server URL first, then optionally add a key.
Solution
Reordered the model selection fields so Base URL comes before API Key for providers that require a base URL.
Changes
Extension UI
runners/extension/popup.html— moved Base URL field above API Keyrunners/extension/popup.js— updated layout comment to match new field orderIssue
N/A
Summary by CodeRabbit