Skip to content

test/unpack_strategy: run extract with verbose#23070

Merged
cho-m merged 1 commit into
mainfrom
unpack_strategy-test-verbose
Jul 12, 2026
Merged

test/unpack_strategy: run extract with verbose#23070
cho-m merged 1 commit into
mainfrom
unpack_strategy-test-verbose

Conversation

@cho-m

@cho-m cho-m commented Jul 12, 2026

Copy link
Copy Markdown
Member

Currently Gzip is failing in portable PRs but I can't reproduce it. Adding verbose to see if it gives more useful information

https://github.com/Homebrew/homebrew-core/actions/runs/29179553748/job/86656464924#step:4:322

  Error: UnpackStrategy::Gzip #extract
  
  Failure/Error: raise ErrorDuringExecution.new(command, status: @status, output: @output, secrets: @secrets)
  
  ErrorDuringExecution:
    Failure while executing; `/usr/bin/env gunzip -q -N -- /var/tmp/homebrew-tests-20260712-93573-91qu2m/temp/d20260712-93573-c36fsq/container.gz` exited with 2.
  Shared Example Group: "#extract" called from ./test/unpack_strategy/gzip_spec.rb:10

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • AI was used to generate or assist with generating this PR.

Copilot AI review requested due to automatic review settings July 12, 2026 17:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the UnpackStrategy extraction shared spec to run extracts in verbose mode to help diagnose an intermittent gunzip failure seen in portable CI runs.

Changes:

  • Pass verbose: true to UnpackStrategy#extract in the shared #extract RSpec example to increase command output during test extraction.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/test/unpack_strategy/shared_examples.rb Outdated
@cho-m cho-m force-pushed the unpack_strategy-test-verbose branch from 41d6ae9 to 58ce87e Compare July 12, 2026 18:17
@cho-m cho-m requested a review from Copilot July 12, 2026 18:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@cho-m cho-m enabled auto-merge July 12, 2026 19:33
@cho-m cho-m added this pull request to the merge queue Jul 12, 2026
Merged via the queue into main with commit 08a9728 Jul 12, 2026
42 checks passed
@cho-m cho-m deleted the unpack_strategy-test-verbose branch July 12, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants