Fix shellenv INFOPATH missing the default in fish#23059
Open
jdelStrother wants to merge 1 commit into
Open
Conversation
Previously, this would generate a single-element array ('/opt/homebrew/share/info'), meaning that emacs and co wouldn't look up their own built-in info dirs.
INFOPATH ought to include a trailing colon to allow this, so we now generate a two-element array in fish ('/opt/homebrew/share/info','')
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates brew shellenv’s fish-shell output to ensure INFOPATH preserves the default Info search directories (by ensuring a trailing : semantics via an empty list element), addressing cases where tools like Emacs won’t search their built-in Info dirs.
Changes:
- Document the intended
INFOPATHtrailing-colon behavior. - Update fish
shellenvoutput to initializeINFOPATHso an empty element can be preserved when prepending Homebrew’s Info dir.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "fish_add_path --global --move --path \"${HOMEBREW_PREFIX}/bin\" \"${HOMEBREW_PREFIX}/sbin\";" | ||
| echo "if test -n \"\$MANPATH[1]\"; set --global --export MANPATH '' \$MANPATH; end;" | ||
| echo "if not contains \"${HOMEBREW_PREFIX}/share/info\" \$INFOPATH; set --global --export INFOPATH \"${HOMEBREW_PREFIX}/share/info\" \$INFOPATH; end;" | ||
| echo "if not set --query INFOPATH; set INFOPATH ''; end; if not contains \"${HOMEBREW_PREFIX}/share/info\" \$INFOPATH; set --global --export INFOPATH \"${HOMEBREW_PREFIX}/share/info\" \$INFOPATH; end;" |
| echo "fish_add_path --global --move --path \"${HOMEBREW_PREFIX}/bin\" \"${HOMEBREW_PREFIX}/sbin\";" | ||
| echo "if test -n \"\$MANPATH[1]\"; set --global --export MANPATH '' \$MANPATH; end;" | ||
| echo "if not contains \"${HOMEBREW_PREFIX}/share/info\" \$INFOPATH; set --global --export INFOPATH \"${HOMEBREW_PREFIX}/share/info\" \$INFOPATH; end;" | ||
| echo "if not set --query INFOPATH; set INFOPATH ''; end; if not contains \"${HOMEBREW_PREFIX}/share/info\" \$INFOPATH; set --global --export INFOPATH \"${HOMEBREW_PREFIX}/share/info\" \$INFOPATH; end;" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
brew shellenvin fish would generate a single-element array('/opt/homebrew/share/info'), meaning that emacs and co wouldn't look up their own built-in info dirs. INFOPATH ought to include a trailing colon to allow this, so we now generate a two-element array in fish('/opt/homebrew/share/info','')brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude fable helped me narrow down why emacs was behaving weird. The code change is me.