Skip to content

Test ruby-macho PR 997#23047

Draft
MikeMcQuaid wants to merge 1 commit into
mainfrom
test-ruby-macho-pr-997
Draft

Test ruby-macho PR 997#23047
MikeMcQuaid wants to merge 1 commit into
mainfrom
test-ruby-macho-pr-997

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member
  • Pin ruby-macho to PR 997 so Homebrew can test code signing support before the gem is released.
  • Vendor the git-sourced runtime files so brew can load macho without relying on a pre-existing Bundler checkout.

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • AI was used to generate or assist with generating this PR.

Tragically, OpenAI Codex was used. The shame.


- Pin `ruby-macho` to PR 997 at `d6a9829bd109` so Homebrew
  can test code signing support before the gem is released.
- Vendor the git-sourced runtime files so `brew` can load `macho`
  without relying on a pre-existing Bundler checkout.
- Use `MachO.codesign!` for patched keg binaries to avoid the
  `codesign` signing path this branch is replacing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant