Show posters when printing the schedule#1783
Open
nikoshell wants to merge 1 commit into
Open
Conversation
Member
Preview available
|
Member
|
Thanks for picking this up! I also pushed this branch earlier, but didn't get time to open a PR yet: https://github.com/EuroPython/website/tree/printable-lunch-posters |
Contributor
|
@nikoshell I am here to approve 18bf0a6 but it's in a big part of a big PR that I'm not qualified to approve 😅 |
Contributor
Author
It's not just removing it from here. here is PR #1786 |
96fbeee to
59217d3
Compare
Poster sessions were hidden when printing because
.lunch-break-content { display: none !important; }
in the @media print block suppressed the entire lunch content area.
Changes in ScheduleLayout.astro / @media print:
- Expanded break-inside: avoid to .time, .lunch-break, .posters-inside,
.sched-lunch-events so rows and lunch content stay together
- Added compact print styles for poster cards inside the lunch slot
- Poster cards use existing .ep-session.poster component at 7pt
- Side events (PyLadies Lunch, Communities Lunch) as compact list
- All headed by '13:00 Lunch' bar with visible border separator
89811f4 to
9e41e68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Poster sessions were hidden when printing because
.lunch-break-content { display: none !important; }in the@media printblock suppressed the entire lunch content area.Changes
In
ScheduleLayout.astro/@media print:display: nonefrom.lunch-break-content.ep-session.postercomponent at 7pt@media (min-width: 800px)which matches A4 landscape)Before / After