perf(sichuan): reuse ordinal hand counts#112
Closed
TypeThe0ry wants to merge 1 commit into
Closed
Conversation
Arbousier1
force-pushed
the
codex/perf-sichuan-ordinal-counts
branch
from
July 18, 2026 12:56
731b9c4 to
d02e837
Compare
Collaborator
|
Formal trusted A/B run did not pass: INCONCLUSIVE_NOISE_OR_NO_GAIN. Evidence: https://github.com/EllanServer/MahjongEngine/actions/runs/29645450524. Closing per the performance gate policy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
MahjongTile.ordinal()lookup tables.Why
The Sichuan evaluator repeatedly parsed tile names and rebuilt collections for every waiting-tile candidate.
Impact
Waiting-tile order and complete winning shapes remain byte-for-byte compatible in differential tests. No public API or rules behavior changes.
Evidence
Paired JMH median reductions:
canWin: about 48.9% time and 76.8% allocationevaluate: about 52.4% time and 56.1% allocationwaitingTiles: about 78.3% time and 97.2% allocationValidation
SichuanHuEvaluatorTest, including randomized legal hands and fixed meldsspotlessCheck