perf(riichi): skip structurally impossible discard reactions#111
Closed
TypeThe0ry wants to merge 1 commit into
Closed
perf(riichi): skip structurally impossible discard reactions#111TypeThe0ry wants to merge 1 commit into
TypeThe0ry wants to merge 1 commit into
Conversation
Arbousier1
force-pushed
the
codex/perf-riichi-reaction-gate
branch
from
July 18, 2026 12:56
ef4d2e3 to
aa4313f
Compare
Collaborator
|
Formal trusted A/B run did not pass: INCONCLUSIVE_NOISE_OR_NO_GAIN. Evidence: https://github.com/EllanServer/MahjongEngine/actions/runs/29645449549. Closing per the performance gate policy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Discard reactions were spending most CPU and allocation in
furoChanceShanteneven when the hand could not possibly pon, kan, or chii the discarded tile.Impact
External APIs, event order, action availability, and ron behavior are unchanged. The fast path only skips a search after proving that no structural meld action exists.
Evidence
Paired JMH:
Validation
RiichiReactionStructuralGateTestspotlessCheck