Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 3 | Coursework with jest#1482
Open
meneogbemi42-bit wants to merge 7 commits into
Open
Birmingham | 26-ITP-May | Ogbemi Mene | Sprint 3 | Coursework with jest#1482meneogbemi42-bit wants to merge 7 commits into
meneogbemi42-bit wants to merge 7 commits into
Conversation
meneogbemi42-bit
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
meneogbemi42-bit
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
meneogbemi42-bit
changed the title
This comment has been minimized.
This comment has been minimized.
meneogbemi42-bit
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
meneogbemi42-bit
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
meneogbemi42-bit
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
meneogbemi42-bit
force-pushed
the
coursework/sprint3-r
branch
from
f190c45 to
0f14126
Compare
meneogbemi42-bit
added
Needs Review
LonMcGregor
reviewed
Jul 13, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this task, lots of good varied test cases. I've got a couple of comments about your implementations
| function isProperFraction(numerator, denominator) { | ||
| // TODO: Implement this function | ||
| // A denominator of 0 is mathematically undefined, so it cannot be a proper fraction. | ||
| if (denominator === 0) { |
There was a problem hiding this comment.
Could you combine this condition with the returned expression below?
| // TODO: Implement this function | ||
| // Parse numeric ranks ("2" through "10") | ||
| const numericValue = parseInt(rank, 10); | ||
| if (!isNaN(numericValue) && numericValue >= 2 && numericValue <= 10 && String(numericValue) === rank) { |
There was a problem hiding this comment.
What does String(numericValue) === rank do here?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##Self checklist
Changelist
This PR implements the Sprint-3 exercise solutions and adds rewritten Jest tests — it implements three functions (getAngleType, isProperFraction, getCardValue), adds input validation/edge-case handling, and adds comprehensive Jest test suites for each.