Skip to content

Glasgow | 26-ITP-May | Chan Yat Long | Sprint 1 | Coursework#1371

Open
Motorcycle-lab wants to merge 15 commits into
CodeYourFuture:mainfrom
Motorcycle-lab:acoursework/sprint-1
Open

Glasgow | 26-ITP-May | Chan Yat Long | Sprint 1 | Coursework#1371
Motorcycle-lab wants to merge 15 commits into
CodeYourFuture:mainfrom
Motorcycle-lab:acoursework/sprint-1

Conversation

@Motorcycle-lab

@Motorcycle-lab Motorcycle-lab commented Jun 21, 2026

Copy link
Copy Markdown

London | 25-ITP-May | Carol Owen | Sprint 1 | Alarm Clock

Fill in the template below - remove any sections that don't apply.

Complete the self checklist - replace each empty box in the checklist [ ] with a [x].

Add the label "Needs Review" and you will get review.

Respond to volunteer reviews until the volunteer marks it as "Complete".

Please note: if the PR template is not filled as described above, an automatic GitHub bot will give feedback in the "Conversation" tab of the pull request and not allow the "Needs Review" label to be added until it's fixed.

-->

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I am updating my coursework.

Questions

My update of the coursework ,please help me evaluate it.

@github-actions

This comment has been minimized.

Sign in to view
@Motorcycle-lab Motorcycle-lab added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 21, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 21, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Motorcycle-lab Motorcycle-lab added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 29, 2026
@github-actions

This comment has been minimized.

Sign in to view
1 similar comment
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 29, 2026
@Motorcycle-lab Motorcycle-lab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 29, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 29, 2026
@Motorcycle-lab Motorcycle-lab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 29, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 29, 2026
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 29, 2026
@Motorcycle-lab Motorcycle-lab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 29, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 29, 2026
@Motorcycle-lab Motorcycle-lab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 29, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 29, 2026
@Motorcycle-lab Motorcycle-lab added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 30, 2026
LonMcGregor
LonMcGregor reviewed Jul 1, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start with these tasks.

There are some where you need to finish the tasks,see my comments for hints

Have you done the tasks in part 3, "interpret"?

Comment thread Sprint-1/1-key-exercises/1-count.js
Comment thread Sprint-1/1-key-exercises/3-paths.js
Comment thread Sprint-1/2-mandatory-errors/1.js Outdated
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 1, 2026
@Motorcycle-lab Motorcycle-lab added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 2, 2026
LonMcGregor
LonMcGregor reviewed Jul 4, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work so far on these tasks. Now you just have to finish the tasks in part 3 and you will be finished

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 4, 2026
@Motorcycle-lab Motorcycle-lab mentioned this pull request Jul 7, 2026
Open
@Motorcycle-lab Motorcycle-lab added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 12, 2026
LonMcGregor
LonMcGregor reviewed Jul 13, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on the interpreting tasks, there is still a little more for you to do

Comment thread Sprint-1/3-mandatory-interpret/2-time-format.js Outdated
//After deducting the totalMinutes, and divide the second. How much do he have the totalMinutes ?

// e) What do you think the variable result represents? Can you think of a better name for this variable?
//The total duration of the movieLength.

@LonMcGregor LonMcGregor Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a variable called "movieLength". What would be a better variable name for what is held in result?

Comment thread Sprint-1/3-mandatory-interpret/2-time-format.js Outdated
// f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer
//for one hour = 3600 minutes . 1:00:00
//for 59 minutes = 3540 minutes . 0:59:0
//for seconds = 6 seconds . 0:0:6

@LonMcGregor LonMcGregor Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this answer a bit more? Why did you include these specific examples?

Comment thread Sprint-1/3-mandatory-interpret/1-percentage-change.js
// Read the code and then answer the questions below

// a) How many function calls are there in this file? Write down all the lines where a function call is made
6

@LonMcGregor LonMcGregor Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you read the task again? It asks you to write down the lines with function calls

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 13, 2026
@Motorcycle-lab Motorcycle-lab added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Motorcycle-lab @LonMcGregor