From da02c1e912fadecd14e4f4b736aebcbc57e7b1fc Mon Sep 17 00:00:00 2001
From: Yuri Teixeira <oyuriteixeira@gmail.com>
Date: Wed, 8 Jul 2026 15:56:42 +0200
Subject: [PATCH] feat(notifications): display who's the author
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Display the author in the notification footers for issues and pull requests.
- Link author names to their GitHub profiles.

Made with ♥️ with the help of spotify-hendrix/gpt-5.5 & https://pi.dev
---
 .../notifications/NotificationFooter.test.tsx |  68 ++++++++
 .../notifications/NotificationFooter.tsx      |  69 +++++++-
 .../AccountNotifications.test.tsx.snap        |  38 +++--
 .../NotificationFooter.test.tsx.snap          |  38 +++--
 .../NotificationRow.test.tsx.snap             | 152 +++++++++++++-----
 5 files changed, 298 insertions(+), 67 deletions(-)

diff --git a/src/renderer/components/notifications/NotificationFooter.test.tsx b/src/renderer/components/notifications/NotificationFooter.test.tsx
index a61df87e4..6c9382192 100644
--- a/src/renderer/components/notifications/NotificationFooter.test.tsx
+++ b/src/renderer/components/notifications/NotificationFooter.test.tsx
@@ -63,6 +63,46 @@ describe('renderer/components/notifications/NotificationFooter.tsx', () => {
     expect(tree.container).toMatchSnapshot();
   });
 
+  it.each(['Issue', 'PullRequest'] as const)('should show %s authors on hover', (type) => {
+    const props: NotificationFooterProps = {
+      notification: {
+        ...mockGitifyNotification,
+        subject: {
+          ...mockGitifyNotification.subject,
+          author: {
+            login: 'thread-author',
+            htmlUrl: 'https://github.com/thread-author' as Link,
+            avatarUrl: 'https://avatars.githubusercontent.com/u/123?v=4' as Link,
+            type: 'User' as GitifyNotificationUser['type'],
+          },
+          type,
+        },
+      },
+    };
+
+    renderWithProviders(<NotificationFooter {...props} />);
+
+    expect(screen.getByText('by thread-author')).toHaveClass('hidden', 'group-hover:inline');
+  });
+
+  it('should not show authors for other notification types', () => {
+    const props: NotificationFooterProps = {
+      notification: {
+        ...mockGitifyNotification,
+        subject: {
+          ...mockGitifyNotification.subject,
+          type: 'Release',
+        },
+      },
+    };
+
+    renderWithProviders(<NotificationFooter {...props} />);
+
+    expect(
+      screen.queryByText(`by ${mockGitifyNotification.subject.author!.login}`),
+    ).not.toBeInTheDocument();
+  });
+
   it('should open notification user profile', async () => {
     const openExternalLinkSpy = vi.spyOn(comms, 'openExternalLink').mockImplementation(vi.fn());
 
@@ -89,4 +129,32 @@ describe('renderer/components/notifications/NotificationFooter.tsx', () => {
     expect(openExternalLinkSpy).toHaveBeenCalledTimes(1);
     expect(openExternalLinkSpy).toHaveBeenCalledWith(props.notification.subject.user!.htmlUrl);
   });
+
+  it('should open notification author profile', async () => {
+    const openExternalLinkSpy = vi.spyOn(comms, 'openExternalLink').mockImplementation(vi.fn());
+
+    const props: NotificationFooterProps = {
+      notification: {
+        ...mockGitifyNotification,
+        subject: {
+          ...mockGitifyNotification.subject,
+          author: {
+            login: 'issue-author',
+            htmlUrl: 'https://github.com/issue-author' as Link,
+            avatarUrl: 'https://avatars.githubusercontent.com/u/123?v=4' as Link,
+            type: 'User' as GitifyNotificationUser['type'],
+          },
+          reviews: undefined,
+          type: 'Issue',
+        },
+      },
+    };
+
+    renderWithProviders(<NotificationFooter {...props} />);
+
+    await userEvent.click(screen.getByTestId('view-author-profile'));
+
+    expect(openExternalLinkSpy).toHaveBeenCalledTimes(1);
+    expect(openExternalLinkSpy).toHaveBeenCalledWith(props.notification.subject.author!.htmlUrl);
+  });
 });
diff --git a/src/renderer/components/notifications/NotificationFooter.tsx b/src/renderer/components/notifications/NotificationFooter.tsx
index cacdc51b9..cd4329f7b 100644
--- a/src/renderer/components/notifications/NotificationFooter.tsx
+++ b/src/renderer/components/notifications/NotificationFooter.tsx
@@ -2,7 +2,13 @@ import type { FC, MouseEvent } from 'react';
 
 import { RelativeTime, Stack, Text } from '@primer/react';
 
-import { type GitifyNotification, Opacity, Size } from '../../types';
+import {
+  type GitifyNotification,
+  type GitifyNotificationUser,
+  type SubjectType,
+  Opacity,
+  Size,
+} from '../../types';
 
 import { openUserProfile } from '../../utils/system/links';
 import { cn } from '../../utils/ui/cn';
@@ -13,9 +19,56 @@ export interface NotificationFooterProps {
   notification: GitifyNotification;
 }
 
+const subjectTypesWithVisibleAuthor: SubjectType[] = ['Issue', 'PullRequest'];
+
+function getVisibleAuthor(notification: GitifyNotification): GitifyNotificationUser | undefined {
+  if (!subjectTypesWithVisibleAuthor.includes(notification.subject.type)) {
+    return undefined;
+  }
+
+  return notification.subject.author;
+}
+
+interface NotificationTimestampProps {
+  notification: GitifyNotification;
+}
+
+const NotificationTimestamp: FC<NotificationTimestampProps> = ({
+  notification,
+}: NotificationTimestampProps) => (
+  <Stack direction="horizontal" gap="none">
+    <Text className="pr-1" title={notification.reason.description}>
+      {notification.reason.title}
+    </Text>
+    <RelativeTime datetime={notification.updatedAt} />
+  </Stack>
+);
+
+interface NotificationAuthorProps {
+  author: GitifyNotificationUser;
+}
+
+const NotificationAuthor: FC<NotificationAuthorProps> = ({ author }: NotificationAuthorProps) => (
+  <button
+    className="hidden font-medium hover:underline group-hover:inline"
+    data-testid="view-author-profile"
+    onClick={(event: MouseEvent<HTMLElement>) => {
+      // Don't trigger onClick of parent element.
+      event.stopPropagation();
+      openUserProfile(author);
+    }}
+    title={`Open ${author.login}'s profile ↗`}
+    type="button"
+  >
+    {`by ${author.login}`}
+  </button>
+);
+
 export const NotificationFooter: FC<NotificationFooterProps> = ({
   notification,
 }: NotificationFooterProps) => {
+  const author = getVisibleAuthor(notification);
+
   return (
     <Stack
       align="center"
@@ -46,12 +99,14 @@ export const NotificationFooter: FC<NotificationFooterProps> = ({
         <AvatarWithFallback size={Size.SMALL} userType={notification.display.defaultUserType} />
       )}
 
-      <Stack direction="horizontal" gap="none">
-        <Text className="pr-1" title={notification.reason.description}>
-          {notification.reason.title}
-        </Text>
-        <RelativeTime datetime={notification.updatedAt} />
-      </Stack>
+      {author ? (
+        <Stack direction="horizontal" gap="condensed">
+          <NotificationTimestamp notification={notification} />
+          <NotificationAuthor author={author} />
+        </Stack>
+      ) : (
+        <NotificationTimestamp notification={notification} />
+      )}
 
       <MetricGroup notification={notification} />
     </Stack>
diff --git a/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap b/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap
index 75bded530..d8e3ce5b9 100644
--- a/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap
+++ b/src/renderer/components/notifications/__snapshots__/AccountNotifications.test.tsx.snap
@@ -840,22 +840,40 @@ exports[`renderer/components/notifications/AccountNotifications.tsx > should ren
             class="prc-Stack-Stack-UQ9k6"
             data-align="stretch"
             data-direction="horizontal"
-            data-gap="none"
+            data-gap="condensed"
             data-justify="start"
             data-padding="none"
             data-wrap="nowrap"
           >
-            <span
-              class="pr-1 prc-Text-Text-9mHv3"
-              title="You're watching the repository."
+            <div
+              class="prc-Stack-Stack-UQ9k6"
+              data-align="stretch"
+              data-direction="horizontal"
+              data-gap="none"
+              data-justify="start"
+              data-padding="none"
+              data-wrap="nowrap"
             >
-              Updated
-            </span>
-            <relative-time
-              datetime="2017-05-20T17:51:57.000Z"
+              <span
+                class="pr-1 prc-Text-Text-9mHv3"
+                title="You're watching the repository."
+              >
+                Updated
+              </span>
+              <relative-time
+                datetime="2017-05-20T17:51:57.000Z"
+              >
+                May 20, 2017
+              </relative-time>
+            </div>
+            <button
+              class="hidden font-medium hover:underline group-hover:inline"
+              data-testid="view-author-profile"
+              title="Open gitify-app's profile ↗"
+              type="button"
             >
-              May 20, 2017
-            </relative-time>
+              by gitify-app
+            </button>
           </div>
           <div
             class="flex gap-1"
diff --git a/src/renderer/components/notifications/__snapshots__/NotificationFooter.test.tsx.snap b/src/renderer/components/notifications/__snapshots__/NotificationFooter.test.tsx.snap
index 6c0c0c9af..af6e51d6c 100644
--- a/src/renderer/components/notifications/__snapshots__/NotificationFooter.test.tsx.snap
+++ b/src/renderer/components/notifications/__snapshots__/NotificationFooter.test.tsx.snap
@@ -577,22 +577,40 @@ exports[`renderer/components/notifications/NotificationFooter.tsx > should rende
       class="prc-Stack-Stack-UQ9k6"
       data-align="stretch"
       data-direction="horizontal"
-      data-gap="none"
+      data-gap="condensed"
       data-justify="start"
       data-padding="none"
       data-wrap="nowrap"
     >
-      <span
-        class="pr-1 prc-Text-Text-9mHv3"
-        title="You're watching the repository."
+      <div
+        class="prc-Stack-Stack-UQ9k6"
+        data-align="stretch"
+        data-direction="horizontal"
+        data-gap="none"
+        data-justify="start"
+        data-padding="none"
+        data-wrap="nowrap"
       >
-        Updated
-      </span>
-      <relative-time
-        datetime="2017-05-20T17:51:57.000Z"
+        <span
+          class="pr-1 prc-Text-Text-9mHv3"
+          title="You're watching the repository."
+        >
+          Updated
+        </span>
+        <relative-time
+          datetime="2017-05-20T17:51:57.000Z"
+        >
+          May 20, 2017
+        </relative-time>
+      </div>
+      <button
+        class="hidden font-medium hover:underline group-hover:inline"
+        data-testid="view-author-profile"
+        title="Open gitify-app's profile ↗"
+        type="button"
       >
-        May 20, 2017
-      </relative-time>
+        by gitify-app
+      </button>
     </div>
     <div
       class="flex gap-1"
diff --git a/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap b/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap
index a93609922..3620b65c5 100644
--- a/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap
+++ b/src/renderer/components/notifications/__snapshots__/NotificationRow.test.tsx.snap
@@ -180,22 +180,40 @@ exports[`renderer/components/notifications/NotificationRow.tsx > should render i
             class="prc-Stack-Stack-UQ9k6"
             data-align="stretch"
             data-direction="horizontal"
-            data-gap="none"
+            data-gap="condensed"
             data-justify="start"
             data-padding="none"
             data-wrap="nowrap"
           >
-            <span
-              class="pr-1 prc-Text-Text-9mHv3"
-              title="You're watching the repository."
+            <div
+              class="prc-Stack-Stack-UQ9k6"
+              data-align="stretch"
+              data-direction="horizontal"
+              data-gap="none"
+              data-justify="start"
+              data-padding="none"
+              data-wrap="nowrap"
             >
-              Updated
-            </span>
-            <relative-time
-              datetime="2017-05-20T17:51:57.000Z"
+              <span
+                class="pr-1 prc-Text-Text-9mHv3"
+                title="You're watching the repository."
+              >
+                Updated
+              </span>
+              <relative-time
+                datetime="2017-05-20T17:51:57.000Z"
+              >
+                May 20, 2017
+              </relative-time>
+            </div>
+            <button
+              class="hidden font-medium hover:underline group-hover:inline"
+              data-testid="view-author-profile"
+              title="Open gitify-app's profile ↗"
+              type="button"
             >
-              May 20, 2017
-            </relative-time>
+              by gitify-app
+            </button>
           </div>
           <div
             class="flex gap-1"
@@ -546,22 +564,40 @@ exports[`renderer/components/notifications/NotificationRow.tsx > should render i
             class="prc-Stack-Stack-UQ9k6"
             data-align="stretch"
             data-direction="horizontal"
-            data-gap="none"
+            data-gap="condensed"
             data-justify="start"
             data-padding="none"
             data-wrap="nowrap"
           >
-            <span
-              class="pr-1 prc-Text-Text-9mHv3"
-              title="You're watching the repository."
+            <div
+              class="prc-Stack-Stack-UQ9k6"
+              data-align="stretch"
+              data-direction="horizontal"
+              data-gap="none"
+              data-justify="start"
+              data-padding="none"
+              data-wrap="nowrap"
             >
-              Updated
-            </span>
-            <relative-time
-              datetime="2017-05-20T17:51:57.000Z"
+              <span
+                class="pr-1 prc-Text-Text-9mHv3"
+                title="You're watching the repository."
+              >
+                Updated
+              </span>
+              <relative-time
+                datetime="2017-05-20T17:51:57.000Z"
+              >
+                May 20, 2017
+              </relative-time>
+            </div>
+            <button
+              class="hidden font-medium hover:underline group-hover:inline"
+              data-testid="view-author-profile"
+              title="Open gitify-app's profile ↗"
+              type="button"
             >
-              May 20, 2017
-            </relative-time>
+              by gitify-app
+            </button>
           </div>
           <div
             class="flex gap-1"
@@ -912,22 +948,40 @@ exports[`renderer/components/notifications/NotificationRow.tsx > should render i
             class="prc-Stack-Stack-UQ9k6"
             data-align="stretch"
             data-direction="horizontal"
-            data-gap="none"
+            data-gap="condensed"
             data-justify="start"
             data-padding="none"
             data-wrap="nowrap"
           >
-            <span
-              class="pr-1 prc-Text-Text-9mHv3"
-              title="You're watching the repository."
+            <div
+              class="prc-Stack-Stack-UQ9k6"
+              data-align="stretch"
+              data-direction="horizontal"
+              data-gap="none"
+              data-justify="start"
+              data-padding="none"
+              data-wrap="nowrap"
             >
-              Updated
-            </span>
-            <relative-time
-              datetime="2017-05-20T17:51:57.000Z"
+              <span
+                class="pr-1 prc-Text-Text-9mHv3"
+                title="You're watching the repository."
+              >
+                Updated
+              </span>
+              <relative-time
+                datetime="2017-05-20T17:51:57.000Z"
+              >
+                May 20, 2017
+              </relative-time>
+            </div>
+            <button
+              class="hidden font-medium hover:underline group-hover:inline"
+              data-testid="view-author-profile"
+              title="Open gitify-app's profile ↗"
+              type="button"
             >
-              May 20, 2017
-            </relative-time>
+              by gitify-app
+            </button>
           </div>
           <div
             class="flex gap-1"
@@ -1278,22 +1332,40 @@ exports[`renderer/components/notifications/NotificationRow.tsx > should render i
             class="prc-Stack-Stack-UQ9k6"
             data-align="stretch"
             data-direction="horizontal"
-            data-gap="none"
+            data-gap="condensed"
             data-justify="start"
             data-padding="none"
             data-wrap="nowrap"
           >
-            <span
-              class="pr-1 prc-Text-Text-9mHv3"
-              title="You're watching the repository."
+            <div
+              class="prc-Stack-Stack-UQ9k6"
+              data-align="stretch"
+              data-direction="horizontal"
+              data-gap="none"
+              data-justify="start"
+              data-padding="none"
+              data-wrap="nowrap"
             >
-              Updated
-            </span>
-            <relative-time
-              datetime="2017-05-20T17:51:57.000Z"
+              <span
+                class="pr-1 prc-Text-Text-9mHv3"
+                title="You're watching the repository."
+              >
+                Updated
+              </span>
+              <relative-time
+                datetime="2017-05-20T17:51:57.000Z"
+              >
+                May 20, 2017
+              </relative-time>
+            </div>
+            <button
+              class="hidden font-medium hover:underline group-hover:inline"
+              data-testid="view-author-profile"
+              title="Open gitify-app's profile ↗"
+              type="button"
             >
-              May 20, 2017
-            </relative-time>
+              by gitify-app
+            </button>
           </div>
           <div
             class="flex gap-1"