Replies: 2 comments
-
|
Reproduced with merge queue and latest-push approval enabled: the bottom PR merged, GitHub rebased the upper PR and invalidated its approval, the upper PR was never queued, and the merge dialog kept spinning. Minimal repro: #174. |
Beta Was this translation helpful? Give feedback.
-
|
Additional evidence from a five-PR reproduction:
A five-PR stack exceeds the configured maximum of 3 plus the documented 50% stack buffer, so splitting it across groups is expected. The FAQ says the remaining PRs should continue in subsequent groups; instead, the operation stopped after the first PR. This looks like the server-side stack landing operation losing or invalidating downstream queue entries when their head OIDs are rewritten after the first squash merge. It is broader than approval invalidation alone. Related minimal issue: #174 |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Summary
When a repository requires GitHub Merge Queue on the trunk branch, clicking "Merge stack" on a stacked PR appears to enqueue only the bottom PR. The UI says the stack can be merged together, but the merge queue only recognizes the PR whose base is the protected trunk branch.
Repro
devExpected behavior
Either:
Actual behavior
Only the bottom PR is recognized by merge queue. The upper PR remains unmerged and must be merged manually after the lower PR lands.
Why this is confusing
The button says "Merge stack" and shows a count of PRs, which implies the stack will merge as a unit. With required merge queue, the actual behavior is one-layer-at-a-time.
FYI, our merge queue config is fine:
max_entries_to_build: 5min_entries_to_merge: 1max_entries_to_merge: 3ALLGREENBeta Was this translation helpful? Give feedback.
All reactions