[duplicate-code] Duplicate Code Pattern: Duplicate `var logHelpers` Symbol Across Packages

[github-actions]

🔍 Duplicate Code Pattern: Duplicate var logHelpers Symbol Across Packages

Part of duplicate code analysis: #aw_parent001abc12

Summary

Two files in different packages both declare var logHelpers = logger.New(...) with the same variable name. While Go allows this (they are in separate packages), it creates ambiguity when searching the codebase and slightly deviates from the project's convention of using more descriptive names.

Duplication Details

Pattern: Same logger variable name in different packages

• Severity: Low

• Occurrences: 2 instances

• Locations:

  • internal/mcp/helpers.go (line 11): var logHelpers = logger.New("mcp:helpers")
  • internal/server/http_helpers.go (line 16): var logHelpers = logger.New("server:helpers")

• Code Sample:

  // internal/mcp/helpers.go:11
  var logHelpers = logger.New("mcp:helpers")
  
  // internal/server/http_helpers.go:16
  var logHelpers = logger.New("server:helpers")

  Suggested improvement:

  // internal/mcp/helpers.go
  var logMCPHelpers = logger.New("mcp:helpers")
  
  // internal/server/http_helpers.go
  var logSrvHelpers = logger.New("server:helpers")

Impact Analysis

• Maintainability: A grep -rn 'logHelpers' returns results from two distinct packages, making it harder to quickly scope debug searches. AGENTS.md encourages descriptive names.
• Bug Risk: None — different packages, no collision.
• Code Bloat: Minimal.

Refactoring Recommendations

1. Rename logHelpers → logMCPHelpers in internal/mcp/helpers.go (update ~5 call sites in the file)
2. Rename logHelpers → logSrvHelpers (or logHTTPHelpers) in internal/server/http_helpers.go (update call sites)

Both renames are low-risk and purely cosmetic.

Implementation Checklist

• Rename logHelpers → logMCPHelpers in internal/mcp/helpers.go
• Rename logHelpers → logSrvHelpers in internal/server/http_helpers.go
• Run make test to verify no regressions

Parent Issue

See parent analysis report: #aw_parent001abc12

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• awmgmcpg

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "awmgmcpg"

See Network Configuration for more information.

Generated by Duplicate Code Detector · 56.7 AIC · ⊞ 7.7K · ◷

• expires on Jul 19, 2026, 3:40 AM UTC